Skip to content

Pass in -j N to cmake to speed up desktop testapp build. #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2022
Merged

Pass in -j N to cmake to speed up desktop testapp build. #933

merged 2 commits into from
May 7, 2022

Conversation

@jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented May 6, 2022 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Pass in "-j <number_of_cpus>" to cmake --build when building desktop testapps.

This should speed up the desktop testapp build. Linux improves from ~50min to ~35min. MacOS improves from ~140min to ~90min. Windows does not change (probably ignores the -j parameter).

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Run integration tests in this PR.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov
Pass in -j to cmake --build when building desktop testapps.
a57b550 
This should speed up the desktop testapp build.
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 6, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 6, 2022
@github-actions
Copy link

github-actions bot commented May 6, 2022 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit 18f20ad
Last updated: Sat May 7 02:52 PDT 2022
View integration test log & download artifacts

Failures Configs
database [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  FirebaseDatabaseTest.TestInfoConnected

Add flaky tests to go/fpl-cpp-flake-tracker

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 6, 2022
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label May 6, 2022
@jonsimantov jonsimantov changed the title Pass in -j N to cmake --build when building desktop testapps. Pass in -j N to cmake to speed up desktop testapp build. May 6, 2022
@jonsimantov jonsimantov requested a review from sunmou99 May 6, 2022 22:17
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 6, 2022
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label May 6, 2022
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 6, 2022
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label May 6, 2022
@jonsimantov
Copy link
Contributor Author

jonsimantov commented May 6, 2022

Thanks, I'm also going to see if building the iOS SDK one architecture at a time, but using -j on each one, saves time over building all of the architectures at once. Will revert that if it doesn't have any positive effect.

@jonsimantov jonsimantov force-pushed the desktop_testapps_parallel_build branch from adba2a7 to 6f3f582 Compare May 7, 2022 00:58
@jonsimantov jonsimantov enabled auto-merge (squash) May 7, 2022 00:59
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 7, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 7, 2022
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label May 7, 2022
@jonsimantov jonsimantov merged commit 18f20ad into main May 7, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels May 7, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 7, 2022
@firebase firebase locked and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sunmou99 sunmou99 sunmou99 approved these changes

Assignees

No one assigned

Labels

skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonsimantov @sunmou99